Skip to content

Commit

Permalink
Touch up PR 299 test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
dtolnay committed Sep 22, 2023
1 parent 5e09329 commit 2d34e8f
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 26 deletions.
28 changes: 14 additions & 14 deletions tests/test_identifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,31 +46,31 @@ fn test_eq() {

#[test]
fn test_comparator() {
let compatator = comparator("4.4.5-44");
assert_to_string(compatator, "^4.4.5-44");
let parsed = comparator("1.2.3-alpha");
assert_to_string(parsed, "^1.2.3-alpha");

let compatator = comparator("2.X");
assert_to_string(compatator, "2.*");
let parsed = comparator("2.X");
assert_to_string(parsed, "2.*");

let compatator = comparator("2");
assert_to_string(compatator, "^2");
let parsed = comparator("2");
assert_to_string(parsed, "^2");

let compatator = comparator("5.x.x");
assert_to_string(compatator, "5.*");
let parsed = comparator("2.x.x");
assert_to_string(parsed, "2.*");
}

#[test]
fn test_prerelease() {
let err = prerelease_err("88.6688.b.rrrrrrr8.b.6bbbbbbb66.66\0");
let err = prerelease_err("1.b\0");
assert_to_string(err, "unexpected character in pre-release identifier");
}

#[test]
fn test_comparator_err() {
let err = comparator_err("4.4.4-012");
let err = comparator_err("1.2.3-01");
assert_to_string(err, "invalid leading zero in pre-release identifier");

let err = comparator_err("5.4.4+4.");
let err = comparator_err("1.2.3+4.");
assert_to_string(err, "empty identifier segment in build metadata");

let err = comparator_err(">");
Expand All @@ -79,15 +79,15 @@ fn test_comparator_err() {
"unexpected end of input while parsing major version number",
);

let err = comparator_err("4.");
let err = comparator_err("1.");
assert_to_string(
err,
"unexpected end of input while parsing minor version number",
);

let err = comparator_err("4.*.");
let err = comparator_err("1.*.");
assert_to_string(err, "unexpected character after wildcard in version req");

let err = comparator_err("55444.4.45-6+6.4.5.45-5644ÿ");
let err = comparator_err("1.2.3+4ÿ");
assert_to_string(err, "unexpected character 'ÿ' after build metadata");
}
4 changes: 2 additions & 2 deletions tests/test_version.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ fn test_parse() {
let err = version_err("1.2.3-01");
assert_to_string(err, "invalid leading zero in pre-release identifier");

let err = version_err("5.1.5++");
let err = version_err("1.2.3++");
assert_to_string(err, "empty identifier segment in build metadata");

let err = version_err("07");
assert_to_string(err, "invalid leading zero in major version number");

let err = version_err("75774777777757777757");
let err = version_err("111111111111111111111.0.0");
assert_to_string(err, "value of major version number exceeds u64::MAX");

let err = version_err("8\0");
Expand Down
20 changes: 10 additions & 10 deletions tests/util/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ pub(super) fn req_err(text: &str) -> Error {
VersionReq::parse(text).unwrap_err()
}

#[cfg_attr(not(no_track_caller), track_caller)]
pub(super) fn comparator(text: &str) -> Comparator {
Comparator::parse(text).unwrap()
}

#[cfg_attr(not(no_track_caller), track_caller)]
pub(super) fn comparator_err(text: &str) -> Error {
Comparator::parse(text).unwrap_err()
}

#[cfg_attr(not(no_track_caller), track_caller)]
pub(super) fn prerelease(text: &str) -> Prerelease {
Prerelease::new(text).unwrap()
Expand All @@ -42,13 +52,3 @@ pub(super) fn build_metadata(text: &str) -> BuildMetadata {
pub(super) fn assert_to_string(value: impl Display, expected: &str) {
assert_eq!(value.to_string(), expected);
}

#[cfg_attr(not(no_track_caller), track_caller)]
pub(super) fn comparator(text: &str) -> Comparator {
Comparator::parse(text).unwrap()
}

#[cfg_attr(not(no_track_caller), track_caller)]
pub(super) fn comparator_err(text: &str) -> Error {
Comparator::parse(text).unwrap_err()
}

0 comments on commit 2d34e8f

Please sign in to comment.