Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Major predicate in favor of empty predicates (fixes #150) #151

Closed
wants to merge 1 commit into from
Closed

Remove Major predicate in favor of empty predicates (fixes #150) #151

wants to merge 1 commit into from

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Nov 8, 2017

Building will fail until a published version of steveklabnik/semver-parser#29 is available.

Bumped version to 0.9.0 because:

  • WildcardVersion lost the Major variant.
  • Ordering of VersionReq is changed for the empty set of predicates which are now wildcards.

@opilar
Copy link
Contributor

opilar commented Nov 27, 2017

Oh. The author needs to push new version of semver-parser

@steveklabnik
Copy link
Contributor

Yes, I've been doing some work and haven't cut a new release yet.

@steveklabnik
Copy link
Contributor

I am not going to be accepting this PR, sorry. There are some breaking changes, and I want to move away from semver-parser entirely anyway. Thank you / sorry

@udoprog udoprog deleted the wildcard branch May 25, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants