remove whitespace from Display impl of VersionReq #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't find precedent for putting spaces in version requirements anywhere else on the web, so this seems like a wild thing to do by default. Both node-semver and https://docs.racket-lang.org/semver/index.html have their version requirements shown without spaces.
|
will be broken until #197 |
hone
added a commit
to hone/semver
that referenced
this pull request
Jul 22, 2020
hone
added a commit
to hone/semver
that referenced
this pull request
Jul 22, 2020
Fabian-Gruenbichler
added a commit
to Fabian-Gruenbichler/semver
that referenced
this pull request
Apr 30, 2021
before: `cargo test --features ci`
...
running 6 tests
test deserialize_identifier ... ok
test serialize_identifier ... ok
test deserialize_version ... ok
test serialize_version ... ok
test serialize_versionreq ... FAILED
test deserialize_versionreq ... ok
failures:
---- serialize_versionreq stdout ----
thread 'serialize_versionreq' panicked at 'assertion failed: `(left == right)`
left: `"\"=1.0.0\""`,
right: `"\"= 1.0.0\""`', tests/serde.rs:84:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
serialize_versionreq
test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Fixes: 5e87530 fix tests and formatting to comply with dtolnay#196
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find precedent for putting spaces in version requirements anywhere else on the web, so this seems like a wild thing to do by default. Both node-semver and https://docs.racket-lang.org/semver/index.html have their version requirements shown without spaces.