Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Version 0.5.0 cannot be used with clap because it enables a non-"additive" feature of yaml-rust and breaks the API #33

Closed
emk opened this issue Nov 13, 2016 · 3 comments
Closed

Version 0.5.0 cannot be used with clap because it enables a non-"additive" feature of yaml-rust and breaks the API #33

emk opened this issue Nov 13, 2016 · 3 comments

Comments

@emk
Copy link

emk commented Nov 13, 2016

The details are available here: clap-rs/clap#747

The basic issue is that serde-yaml turns on yaml-rust's preserve_order feature, which changes the API of yaml-rust in a breaking fashion, and makes it impossible to use certain third-party crates.
emk added a commit to emk/compose_yml that referenced this issue Nov 13, 2016
@emk
v0.0.47: Revert "Upgrade to latest serde_yaml" and use 0.4.1 instead
f33d12b 
This reverts commit 7cc3be9.

See clap-rs/clap#747 and
dtolnay/serde-yaml#33 for more details.
@emk emk mentioned this issue Nov 13, 2016
Closed
@emk emk changed the title Version 0.5.0 cannot be used with clap Version 0.5.0 cannot be used with clap because it enables a non-"additive" feature of yaml-rust and breaks the API Nov 13, 2016
@emk
Copy link
Author

emk commented Nov 13, 2016

The underlying issue with yaml-rust is discussed in more detail here: chyh1990/yaml-rust#44

In light of the fact that enabling this option breaks API compatibility for other users of yaml-rust, it might be best to just leave it disabled until a solution is found at the yaml-rust level.

@kbknapp
Copy link

kbknapp commented Nov 14, 2016

The best outcome (for me at least) is to provide the option to not use preserve_order with yaml-rust since changing clap's API to match the preserve_order would be a breaking change. I'll be standing by for suggestions and comments though.

@robinst robinst mentioned this issue Jul 4, 2017
Closed
@dtolnay
Copy link
Owner

dtolnay commented Jul 28, 2022

As of 0.9, serde-yaml no longer depends on yaml-rust.

@dtolnay dtolnay closed this as completed Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emk @dtolnay @kbknapp