Remove rust as a submodule
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `tests/rust` submodule and instead moves to lazily cloning it during tests. This helps work around the fact that git dependencies on `syn` will pull in all submodules, and rust takes forever to clone. In short, the intention here is to make git dependencies on `syn` bearable to avoid Cargo auto-cloning submodules.
Closed
|
This is a very good idea :). I was going to suggest only shallow-cloning the repository so it clones faster, but it seems like that's a tad tricky to do as you can't shallow-clone based on a commit. Perhaps we could skip git cloning at all, and just download a zip with the repo at that commit from github (like https://github.com/rust-lang/rust/archive/ddc5d7bd4b9ea3e8a8ccf82cb443e950be311d61.zip), unzip that, and use it? |
|
This is typically only run on builders so I figured it wasn't worth the 30 or so seconds saved for going out of our way to get shallow clones working. |
|
r? @mystor |
mystor
approved these changes
Jul 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
tests/rustsubmodule and instead moves to lazily cloning itduring tests. This helps work around the fact that git dependencies on
synwill pull in all submodules, and rust takes forever to clone. In short, the
intention here is to make git dependencies on
synbearable to avoid Cargoauto-cloning submodules.