Add a feature for linking to proc_macro. #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure what travis.yml changes you wanted here, since it looks like it builds in some subset of possible configurations but only tests the configuration with all the features. |
|
Thank you! I filed #369 to reopen and merge this PR during the next round of breaking changes. |
staktrace
added a commit
to staktrace/cbindgen
that referenced
this pull request
Mar 5, 2018
Fixes mozilla#137. standalone-syn 0.13.0 contains the deferred PR dtolnay/syn#363 which allows turning off the "proc-macro" feature. This is the desired approach to fixing the dylib dependency problem, and allows cbindgen to once again be buildable by the release rustc compiler.
eqrion
pushed a commit
to mozilla/cbindgen
that referenced
this pull request
Mar 6, 2018
Fixes #137. standalone-syn 0.13.0 contains the deferred PR dtolnay/syn#363 which allows turning off the "proc-macro" feature. This is the desired approach to fixing the dylib dependency problem, and allows cbindgen to once again be buildable by the release rustc compiler.
This feature is enabled by default for backwards compatibility, but it can be disabled in order to break the runtime dependency on the dynamic library libproc_macro in the rustc toolchain.
dtolnay
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is enabled by default for backwards compatibility, but
it can be disabled in order to break the runtime dependency on the
dynamic library libproc_macro in the rustc toolchain.
This PR assumes that there is a version 0.5.0 or higher of
quoteon crates.io that includes dtolnay/quote#62. That is not yet the case (see dtolnay/quote#62 (comment))