Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate any spawned commit transaction prior adding them to the wallet #1050

Open
6 tasks
frolosofsky opened this issue May 2, 2019 · 0 comments
Open
6 tasks
Labels
bug A problem of existing functionality wallet
Milestone

Comments

@frolosofsky
Copy link
Member

frolosofsky commented May 2, 2019

As has been described in the #996 (comment), node could keep invalid spawned finalizer commit transactions in the wallet because there's a lack of validation of them prior adding to the wallet.

This could be fixed in a similar way as #1040 does it for deposit transactions. @kostyantyn also came with a proposal to use ContextualCheck: #1040 (comment). 3rd option is to apply the full transaction validation path.

User-driven commits (definitely must be fixed):

System-driven commits (needs more investigation):

  • vote
  • slash
@frolosofsky frolosofsky added bug A problem of existing functionality wallet labels May 2, 2019
@frolosofsky frolosofsky added this to the 0.2 milestone May 2, 2019
@frolosofsky frolosofsky changed the title Validate or contextual check any spawned commit transaction prior adding them to the wallet Validate any spawned commit transaction prior adding them to the wallet May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem of existing functionality wallet
Projects
None yet
Development

No branches or pull requests

1 participant