Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits full sync degrades to the headers full sync #967

Open
frolosofsky opened this issue Apr 12, 2019 · 0 comments
Open

Commits full sync degrades to the headers full sync #967

frolosofsky opened this issue Apr 12, 2019 · 0 comments
Labels
bug A problem of existing functionality
Milestone

Comments

@frolosofsky
Copy link
Member

Describe the bug
After processing some amount of headers+commits messages (several thousands or alike in my current scenario), commits exchange fade out, and node fallbacks to the headers full sync. After new peer connected, node initializes new commits+headers exchange round but it seems that both syncs work in parallel (commits have priority within the peer btw).

To Reproduce

  1. Launch unit-e in testnet.
  2. See logs. Grep hints: headers+commits, commits full sync asked.

Expected behavior
During full sync, only headers+commits must transfer headers.

The normal behavior:

2019-04-12 08:51:52 [finalization] Process commits block_hash=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 height=2

...

2019-04-12 08:51:52 [         net] received block 78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 peer=0
2019-04-12 08:51:52 [finalization] Process candidate tip block_hash=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 height=2
2019-04-12 08:51:52 [finalization] State for block_hash=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 heigh=2 has been processed from commits, confirming...
2019-04-12 08:51:52 [finalization] State for block_hash=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 height=2 confirmed
2019-04-12 08:51:52 [finalization] Process tip block_hash=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 height=2
2019-04-12 08:51:52 [finalization] State for block_hash=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 height=2 has been already processed
2019-04-12 08:51:52 [            ] UpdateTip: new best=78eb9a84c5bf412405373d8684dc10249e0a83818a29eeeb60aafece1a46bb19 height=2 version=0x00000001 log2_work=54.701305 tx=3 date='2019-04-11 15:36:48' progress=1.000000 cache=0.1MiB(641txo)

Note messages "process commits" and "State ... has been processed from commits, confirming..."

Abnormal:

2019-04-12 09:23:43 [finalization] Process candidate tip block_hash=248ce01c8a54a3a5ab8a73ee9ef838c9fde487adc62e3fcb0200202936340218 height=7000
2019-04-12 09:23:43 [finalization] ProcessNewCommits: Last block of the epoch, new m_recommended_target_hash=248ce01c8a54a3a5ab8a73ee9ef838c9fde4
87adc62e3fcb0200202936340218
2019-04-12 09:23:43 [            ] Read 218d34be057dae2c3466b1ed70db3907aca605012a5fb9a95c19a0c3e733dab3 from the disk

...

2019-04-12 09:24:16 [finalization] Process tip block_hash=248ce01c8a54a3a5ab8a73ee9ef838c9fde487adc62e3fcb0200202936340218 height=7000
2019-04-12 09:24:16 [finalization] State for block_hash=248ce01c8a54a3a5ab8a73ee9ef838c9fde487adc62e3fcb0200202936340218 height=7000 has been already processed
2019-04-12 09:24:16 [            ] UpdateTip: new best=248ce01c8a54a3a5ab8a73ee9ef838c9fde487adc62e3fcb0200202936340218 height=7000 version=0x00000001 log2_work=66.700407 tx=601288 date='2019-04-12 06:54:12' progress=1.000000 cache=5.7MiB(39912txo)

Environment
Master dee0b86

@frolosofsky frolosofsky added the bug A problem of existing functionality label Apr 12, 2019
@thothd thothd added this to the 0.2 milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants