Feature notifications timeout fix #712
Conversation
Signed-off-by: Dmitry Saveliev <dima@thirdhash.com>
dsaveliev
force-pushed
the
feature-notifications-timeout-fix
branch
from
a894b00
to
78707e5
Compare
There was a problem hiding this comment.
utACK 78707e5 , regardless of my misgivings about -alertnotify and -blocknotify features themselves, which allow running arbitrary shell commands on the user's machine.
Note: Someone with admin access to the repository should merge this PR without squashing, to preserve commit authorship.
I agree on that, but this is a separate, big topic for discussion. |
There was a problem hiding this comment.
Note from the original PR bitcoin/bitcoin#14275 (comment)
Could you explain the race condition?
Bitcoin Core runs the each notification command in new thread, so it would have 10 process writing the same file if it generate 10 blocks immediately in this tests.
utACK 78707e5
Fixes #373
This is a port of bitcoin/bitcoin#14670
A timeout occurs during blocks generation in "feature_notifications" test.
I suspect that it might happen due to the log file locking - "BlockNotifyCallback" is executing the notification command in a separate thread and each command tries to write data to the same log file asynchronously.
The aforementioned port should help to eliminate such kind of errors.
Test run:
https://travis-ci.com/dsaveliev/unit-e/jobs/181612551
Signed-off-by: Dmitry Saveliev dima@thirdhash.com