Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: when hashBasedNavigation is true and url route can't be found, apps become unresponsive #48

Open
giacomocerquone opened this issue Aug 21, 2024 · 1 comment · May be fixed by #49

Comments

@giacomocerquone
Copy link

giacomocerquone commented Aug 21, 2024

When hashBasedNavigation is true and a 404 link is pressed, there is an infinite update loop that makes the app go totally unresponsive.
To reproduce this just convert the UI folder of this repo to use the hashBasedNavigation and insert an inexistent link wherever you want and notice the behavior.

FYI: Right now links in markdown when hashBasedNavigation is true should start with an hashtag (#/guides/whatever), but the bug can be reproduced either way of course.

Check the screencast:

Screen.Recording.2024-08-22.at.00.17.02.mov

Please notice the url which demonstrate I'm hitting an inexistent link.

Screenshot 2024-08-22 at 00 26 45

@giacomocerquone
Copy link
Author

Btw you @georgesboris probably noticed already this issue here in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant