This repository has been archived by the owner on Jul 30, 2023. It is now read-only.
feat: colorize only ttys #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually kubectl is also used in aliases such as the ones available as zsh plugins (https://github.com/ohmyzsh/ohmyzsh/blob/master/plugins/kubectl/kubectl.plugin.zsh). Unfortunately if you alias k to kubecolor, you won't be able to get commands such as `kcn` to work because the output in the subshell will be colorized as well. This commit checks whether the user is running the command in a TTY, and returns the colorized version only in this case, so that kubecolor and kubectl subshell commands can coexist.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually kubectl is also used in aliases such as the ones
available as zsh plugins (https://github.com/ohmyzsh/ohmyzsh/blob/master/plugins/kubectl/kubectl.plugin.zsh).
Unfortunately if you alias k to kubecolor, you won't be able to get commands such as
kcnto work because the output in the subshell will be colorized as well.This commit checks whether the user is running the command in a TTY, and returns the colorized version only in this case, so that kubecolor and kubectl subshell commands can coexist.
Example:
