Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency and tests #11

Merged
merged 6 commits into from Nov 20, 2019
Merged

Conversation

carsonreinke
Copy link
Contributor

@carsonreinke carsonreinke commented Nov 17, 2019

  • Added concurrent downloads using a goroutine
  • Added download rate limiting
  • Added more test coverage
  • Introduced download-throttle and concurrent-downloads options to control downloading
  • Moved some things around

@carsonreinke carsonreinke changed the title WIP: Add concurrency and tests Add concurrency and tests Nov 18, 2019
@dtylman
Copy link
Owner

dtylman commented Nov 20, 2019

Cool! Thanks!

I actually don't have time to look into it deeply.

It looks good. I am merging.

Thanks for the contribution!!!

@dtylman dtylman closed this Nov 20, 2019
@dtylman dtylman reopened this Nov 20, 2019
@dtylman dtylman merged commit 9fc793c into dtylman:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants