Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free enrolment is broken in 3.4.1 (coupon id and user id arguments swapped) #125

Closed
jimcrammond opened this issue May 30, 2023 · 0 comments · Fixed by #127
Closed

Free enrolment is broken in 3.4.1 (coupon id and user id arguments swapped) #125

jimcrammond opened this issue May 30, 2023 · 0 comments · Fixed by #127

Comments

@jimcrammond
Copy link

Apply a 100% discount coupon. Then hit the Enrol Now button.

The UI appears to do nothing. A message is sent to admin like this:
STRIPE PAYMENT ERROR: Not a valid user id!

In the 3.4.1 release the arguments to the call stripepayment_free_enrolsettings in amd/src/stripe_payment.js are not aligned with the function in externallib.php as the user_id and coupon_id are swapped.
kndnsow added a commit to kndnsow/moodle-enrol_stripepayment that referenced this issue Jun 2, 2023
@kndnsow
update 3.4.2
31419c0 
* Fixed Missing Instance name dualcube#124.
* Fixed Free enrol - coupon id and user id arguments swapped dualcube#125.
* Fixed Successful Enrolment - Exception Error Message (stdClass undefined) dualcube#126.
* Added Script library 10.14.0.
@kndnsow kndnsow mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update 3.4.2 kndnsow/moodle-enrol_stripepayment
1 participant
@jimcrammond