Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question concerning rules to enable #34

Closed
Cycl0pe opened this issue Apr 25, 2019 · 6 comments
Closed

Question concerning rules to enable #34

Cycl0pe opened this issue Apr 25, 2019 · 6 comments

Comments

@Cycl0pe
Copy link

Cycl0pe commented Apr 25, 2019

Hi,

I was wondering how you specify that you want to activate all the security rules (enabled and disabled rules by default) in .soliumrc.json file?

Cycl0pe

@duaraghav8
Copy link
Owner

If I understand correctly, you're looking for a single flag which you could toggle in your configuration to enable/disable all rules, without having to specify them individually. Is that right?

If yes, then currently it is not possible. I thought of enabling all security rules in the solium-all ruleset, but that forces enabling all style rules too.

You're welcome to share how you imagine this could work in the configuration? you can add to the discussion on duaraghav8/Ethlint#252

@Cycl0pe
Copy link
Author

Cycl0pe commented Apr 25, 2019

Well, I was looking for a way to enable one or all rules disabled by default but I do not know how to do it in the configuration file.

Cycl0pe

@duaraghav8
Copy link
Owner

To clarify, you cannot to that at the moment. You will have to specify all rules as enabled separately in your soliumrc.
The issue I've pointed you to is for allowing people to give ideas on how this can be improved.

@Cycl0pe
Copy link
Author

Cycl0pe commented Apr 26, 2019

I do understand that but how do you enable one specific rule in .soliumrc.json? I did not find any documentation about it.

Thanks

@duaraghav8
Copy link
Owner

duaraghav8 commented Apr 26, 2019

The documentation is under Plugins https://ethlint.readthedocs.io/en/latest/user-guide.html#plugins
eg

{
  "plugins": ["security"],
  "rules": {
    "security/rule-name": "error"
  }
}

@Cycl0pe
Copy link
Author

Cycl0pe commented Apr 26, 2019

Thanks for your help. I was missing the keyword "security".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants