Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non reloading config #297

Merged
merged 1 commit into from Jan 30, 2020
Merged

Conversation

dansanduleac
Copy link
Contributor

@dansanduleac dansanduleac commented Jan 23, 2020

Before this PR

Once config has been loaded once, it will not be loaded again.

After this PR

Config is reloaded every time the .idea/saveactions_settings.xml file changes.
Fixes #295.

I've tested this by debugging runIde and noticing that originally, Storage.loadState would only get called once then never again, even after I modify the file.

With this change, loadState gets called every time as expected, and the UI also updates accordingly when opened.

@dubreuia
Copy link
Owner

Thanks a lot for the PR. I don't get how changing "./saveactions_settings.xml" to "saveactions_settings.xml" might work but I'll test it out :-)

@dansanduleac
Copy link
Contributor Author

dansanduleac commented Jan 24, 2020

They must do some simple path appending without any normalisation, and then when they get a changed path event, the paths don't match. It's most likely something that can be fixed upstream but I didn't have the time to look into it deeply.

@dansanduleac
Copy link
Contributor Author

@dubreuia any chance you could merge this soon? :)
The lack of reloading is causing a bit of friction on every new repo as it requires reloading the project through Gradle, then closing it, then opening it again.

@dubreuia
Copy link
Owner

Sorry l have a lot of work atm. Should be able to merge and release for next week

@dubreuia dubreuia added this to the 1.10.0 milestone Jan 29, 2020
@dubreuia
Copy link
Owner

LGTM

@dubreuia dubreuia merged commit 1b32586 into dubreuia:master Jan 30, 2020
@dubreuia
Copy link
Owner

@dansanduleac there's a couple of issue I'll release with this one (version 2.0.0), I'll release over the weekend

@dubreuia
Copy link
Owner

dubreuia commented Feb 1, 2020

Released in 2.0.0 (https://plugins.jetbrains.com/plugin/7642-save-actions/update/77136 / https://github.com/dubreuia/intellij-plugin-save-actions/releases/tag/v2.0.0)

@dansanduleac dansanduleac deleted the ds/fix-config branch February 4, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.idea/saveactions_settings.xml not automatically reloaded
2 participants