Build for idea version 2021.3. Fixed #391 #392
Conversation
|
LGTM |
|
This commit seems also to be valid for 2021.2.3. I used it the whole day without any issues neither on 2021.3 nor on 2021.2.3. |
|
plz implement this. the stupid action on save doesn't help a lot :( |
| import javax.swing.JComboBox; | ||
| import javax.swing.JComponent; | ||
| import javax.swing.JPanel; | ||
| import javax.swing.*; |
There was a problem hiding this comment.
I think you should keep these imports instead of use *
| import javax.swing.event.ListDataEvent; | ||
| import javax.swing.event.ListDataListener; | ||
| import java.awt.BorderLayout; | ||
| import java.awt.Dimension; | ||
| import java.awt.*; |
There was a problem hiding this comment.
I think you should keep these imports instead of use *
| import javax.swing.JPanel; | ||
| import java.awt.BorderLayout; | ||
| import java.awt.Dimension; | ||
| import javax.swing.*; |
There was a problem hiding this comment.
I think you should keep these imports instead of use *
There was a problem hiding this comment.
Agree. I used the code style attached to this project.
There was a problem hiding this comment.
Should be fixed by the last commit.
|
Now I think we need to wait @dubreuia blessing :) |
Did he go MIA somewhere? |
Meanwhile, you can build the plugin yourself locally and install it locally. Choose the gear under Plugin and select install from disk. |
|
Looking, thanks for the work |
Recently, I spent more time in removing all pending deprecated API calls and made the Plugin reloadable. Let me know if I should update this PR. |
|
|
@sfragata @fishermans Thank you so much for your work on the plugin, I really appreciate it 🙏 I've uploaded plugin version 2.3.0 to Jetbrains plugin repo, should be up by Monday. I've tested the plugin on my side, the changes looks ok to me.
@fishermans That would be great if you don't mind preparing another PR? Sorry I already merged & released this one, I wanted to push the new version ASAP. Still good to cleanup & improve |
You are welcome! I am using your Plugin each day. Thus, I have to say THANK YOU! |
|
@dubreuia all cheers to @fishermans , He did the fix, I did the review ;) Thank you for the great plugin, my team uses Eclipse and Intelj so I need to use the same formatter/organizer, so your plugin is perfect for my needs |
Please find my fixes for #391. Hopefully, it fixes all issues.