Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

231 refactoring #398

Merged
merged 9 commits into from Dec 19, 2021
Merged

231 refactoring #398

merged 9 commits into from Dec 19, 2021

Conversation

fishermans
Copy link
Contributor

Hi @dubreuia,

I spent some more time keeping this wonderful plugin updated.

Main change is moving to services and removing component implementation regarding https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html.

I also implemented a FileDocumentManagerListener and registering it to the EP which should be a cleaner way then using the message bus. At this point, we can decide whether to register multiple Listener for each project or using an application based listener for all projects and iterating over the projects. As long as changed documents are held systemwide, it would not make any difference from my-point-of-view.

I tested it on Idea, RubyMine and Resharper.

Please review my changes when you find some time.

BR
Tiemo

@fishermans
Copy link
Contributor Author

fishermans commented Dec 13, 2021

Should also fix #384 and #383

@dubreuia
Copy link
Owner

dubreuia commented Dec 19, 2021

Thanks a lot @fishermans for those fixes 🙏 ! Merging and testing on my side, I'll try a release ASAP

Thank you to @abimarank for the review as well

EDIT: tests OK 👍

@dubreuia dubreuia self-requested a review December 19, 2021 17:13
@dubreuia dubreuia merged commit 0ecbd5a into dubreuia:main Dec 19, 2021
@dubreuia
Copy link
Owner

@fishermans - nitpicking on your pull request: you don't need to change the versions (like 2.3.1), I do it when I release I have a script which automates it (./scripts/release.sh)

Also I'm following semver so I don't increment the maintenance version for bugs / new features, here we go from 2.3.0 to 2.4.0. The version 2.3.1 would be a quick fix / hot fix or security patch (no new features)

@dubreuia
Copy link
Owner

@dubreuia
Copy link
Owner

Plugin uploaded pending verification, thanks again

@fishermans fishermans deleted the 231_refactoring branch December 19, 2021 19:30
@fishermans
Copy link
Contributor Author

Thanks a lot @dubreuia!

Maybe we can clean up some of the old tickets to have a better overview of what still needs to be done.

I guess, the option "Remove unused suppressed warning annotation" should be removed as long as this function is not working as expected. It removes too much at the moment and I haven't figured out how to fix it. See #87 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants