Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gym/common] Fix circular reference issue preventing garbage collection. #715

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

duburcqa
Copy link
Owner

@duburcqa duburcqa commented Feb 11, 2024

  • [python/viewer] Fix meshcat zmq socket not properly closed.
  • [gym/common] Fix circular reference issue preventing garbage collection.

Fixes #712

@duburcqa duburcqa enabled auto-merge (squash) February 11, 2024 21:35
@duburcqa duburcqa merged commit d75d308 into dev Feb 11, 2024
27 of 28 checks passed
duburcqa added a commit that referenced this pull request Feb 11, 2024
…on. (#715)

* [python/viewer] Fix meshcat zmq socket not properly closed.
* [gym/common] Fix circular reference issue preventing garbage collection.
@duburcqa duburcqa deleted the gc_circ branch February 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] Use weakref.proxy instead of weakref.ref to simplify logic
1 participant