Factorize creation of ExecutionTree

dubzzz · Dec 21, 2018 · a46f079 · a46f079
1 parent a5fefe3
commit a46f079
Showing 1 changed file with 9 additions and 16 deletions.
diff --git a/src/check/runner/reporter/RunExecution.ts b/src/check/runner/reporter/RunExecution.ts
@@ -26,14 +26,15 @@ export class RunExecution<Ts> {
     this.numSuccesses = 0;
   }
 
+  private appendExecutionTree(status: ExecutionStatus, value: Ts) {
+    const currentTree: ExecutionTree<Ts> = { status, value, children: [] };
+    this.currentLevelExecutionTrees.push(currentTree);
+    return currentTree;
+  }
+
   fail(value: Ts, id: number, message: string) {
     if (this.verbosity >= VerbosityLevel.Verbose) {
-      const currentTree: ExecutionTree<Ts> = {
-        status: ExecutionStatus.Failure,
-        value,
-        children: []
-      };
-      this.currentLevelExecutionTrees.push(currentTree);
+      const currentTree = this.appendExecutionTree(ExecutionStatus.Failure, value);
       this.currentLevelExecutionTrees = currentTree.children;
     }
     if (this.pathToFailure == null) this.pathToFailure = `${id}`;
@@ -43,23 +44,15 @@ export class RunExecution<Ts> {
   }
   skip(value: Ts) {
     if (this.verbosity >= VerbosityLevel.VeryVerbose) {
-      this.currentLevelExecutionTrees.push({
-        status: ExecutionStatus.Skipped,
-        value,
-        children: []
-      });
+      this.appendExecutionTree(ExecutionStatus.Skipped, value);
     }
     if (this.pathToFailure == null) {
       ++this.numSkips;
     }
   }
   success(value: Ts) {
     if (this.verbosity >= VerbosityLevel.VeryVerbose) {
-      this.currentLevelExecutionTrees.push({
-        status: ExecutionStatus.Success,
-        value,
-        children: []
-      });
+      this.appendExecutionTree(ExecutionStatus.Success, value);
     }
     if (this.pathToFailure == null) {
       ++this.numSuccesses;