Update linter configuration

Fixes #246
dubzzz · Nov 26, 2018 · fd8e00c · fd8e00c
1 parent b932e54
commit fd8e00c
Show file tree

Hide file tree

Showing 14 changed files with 29 additions and 34 deletions.
diff --git a/prebuild/property.ts b/prebuild/property.ts
@@ -1,4 +1,4 @@
-import { arbCommas, commas, iota, joiner, txCommas } from './helpers';
+import { commas, iota, joiner, txCommas } from './helpers';
 
 const predicateFor = (num: number, isAsync: boolean): string =>
   isAsync

diff --git a/test/e2e/GenerateAllValues.spec.ts b/test/e2e/GenerateAllValues.spec.ts
@@ -1,4 +1,3 @@
-import * as assert from 'assert';
 import * as prand from 'pure-rand';
 import * as fc from '../../src/fast-check';
 

diff --git a/test/e2e/ModelBased.spec.ts b/test/e2e/ModelBased.spec.ts
@@ -1,5 +1,4 @@
 import * as assert from 'assert';
-import * as prand from 'pure-rand';
 import * as fc from '../../src/fast-check';
 
 interface IList<T> {
@@ -8,7 +7,9 @@ interface IList<T> {
   size(): number;
 }
 
-type Model = { num: number };
+interface Model {
+  num: number;
+}
 
 class PushCommand implements fc.Command<Model, IList<number>> {
   constructor(readonly value: number) {}
@@ -66,8 +67,8 @@ describe(`Model Based (seed: ${seed})`, () => {
           start: number = 0;
           end: number = 0;
           data: number[];
-          constructor(size: number) {
-            this.data = [...Array(size)].fill(null);
+          constructor(len: number) {
+            this.data = [...Array(len)].fill(null);
           }
           push = (v: number) => {
             this.data[this.end] = v;

diff --git a/test/e2e/Shadows.spec.ts b/test/e2e/Shadows.spec.ts
@@ -39,7 +39,7 @@ class Space {
   }
   toString() {
     return `Space(grid{x:${this.dim_x},y:${this.dim_y}},solution{x:${this.solution_x},y:${this.solution_y}},initial{x:${
-      this.initial_y
+      this.initial_x
     },y:${this.initial_y}})`;
   }
 }

diff --git a/test/unit/check/arbitrary/ConstantArbitrary.spec.ts b/test/unit/check/arbitrary/ConstantArbitrary.spec.ts
@@ -2,9 +2,9 @@ import * as assert from 'assert';
 import * as fc from '../../../../lib/fast-check';
 
 import { clonedConstant, constant, constantFrom } from '../../../../src/check/arbitrary/ConstantArbitrary';
+import { cloneMethod } from '../../../../src/fast-check';
 
 import * as stubRng from '../../stubs/generators';
-import { cloneMethod } from '../../../../src/fast-check';
 
 const cloneable = { [cloneMethod]: () => cloneable };
 
@@ -16,7 +16,7 @@ describe('ConstantArbitrary', () => {
       assert.equal(g, 42);
     });
     it('Should always return the original instance', () => {
-      let instance = ['hello'];
+      const instance = ['hello'];
       const mrng = stubRng.mutable.nocall();
       const g = constant(instance).generate(mrng).value;
       assert.deepEqual(g, ['hello']);
@@ -44,7 +44,7 @@ describe('ConstantArbitrary', () => {
         fc.property(fc.array(fc.string(), 1, 10), fc.integer(), fc.nat(), (data, seed, idx) => {
           const mrng = stubRng.mutable.fastincrease(seed);
           const arb = constantFrom(...data);
-          for (let id = 0; id != 10000; ++id) {
+          for (let id = 0; id !== 10000; ++id) {
             const g = arb.generate(mrng).value;
             if (g === data[idx % data.length]) return true;
           }
@@ -72,11 +72,12 @@ describe('ConstantArbitrary', () => {
       let clonedOnce = false;
       const mrng = stubRng.mutable.nocall();
       const g = clonedConstant({
-        [cloneMethod]: function() {
+        [cloneMethod]() {
           clonedOnce = true;
           return this;
         }
       }).generate(mrng).value;
+      assert.ok(g != null);
       assert.ok(clonedOnce);
     });
   });

diff --git a/test/unit/check/arbitrary/FrequencyArbitrary.spec.ts b/test/unit/check/arbitrary/FrequencyArbitrary.spec.ts
@@ -1,4 +1,3 @@
-import * as assert from 'assert';
 import * as fc from '../../../../lib/fast-check';
 
 import { frequency } from '../../../../src/check/arbitrary/FrequencyArbitrary';
@@ -19,7 +18,7 @@ describe('FrequencyArbitrary', () => {
             rng(seed)
           ).value;
           const gOneOf = oneof(...choices.map(stubArb.counter)).generate(rng(seed)).value;
-          return gFreq == gOneOf;
+          return gFreq === gOneOf;
         })
       ));
     it('Should produce the same as oneof with sum of weights elements', () =>
@@ -33,7 +32,7 @@ describe('FrequencyArbitrary', () => {
             ...choices.map(c => Object({ weight: c[1], arbitrary: stubArb.counter(c[0]) }))
           ).generate(rng(seed)).value;
           const gOneOf = oneof(...choicesOneOf.map(stubArb.counter)).generate(rng(seed)).value;
-          return gFreq == gOneOf;
+          return gFreq === gOneOf;
         })
       ));
   });

diff --git a/test/unit/check/arbitrary/ObjectArbitrary.spec.ts b/test/unit/check/arbitrary/ObjectArbitrary.spec.ts
@@ -9,8 +9,7 @@ import {
   jsonObject,
   unicodeJsonObject,
   json,
-  unicodeJson,
-  ObjectConstraints
+  unicodeJson
 } from '../../../../src/check/arbitrary/ObjectArbitrary';
 
 import * as stubRng from '../../stubs/generators';

diff --git a/test/unit/check/arbitrary/StringArbitrary.spec.ts b/test/unit/check/arbitrary/StringArbitrary.spec.ts
@@ -1,15 +1,14 @@
-import * as assert from 'assert';
 import * as fc from '../../../../lib/fast-check';
 
 import { constantFrom } from '../../../../src/check/arbitrary/ConstantArbitrary';
 import {
-  stringOf,
-  string,
   asciiString,
-  string16bits,
-  unicodeString,
+  base64String,
   hexaString,
-  base64String
+  string,
+  string16bits,
+  stringOf,
+  unicodeString
 } from '../../../../src/check/arbitrary/StringArbitrary';
 
 import * as genericHelper from './generic/GenericArbitraryHelper';

diff --git a/test/unit/check/arbitrary/definition/Arbitrary.spec.ts b/test/unit/check/arbitrary/definition/Arbitrary.spec.ts
@@ -1,17 +1,16 @@
 import * as assert from 'assert';
 import * as fc from '../../../../../lib/fast-check';
 
+import { constant } from '../../../../../src/check/arbitrary/ConstantArbitrary';
 import { Arbitrary } from '../../../../../src/check/arbitrary/definition/Arbitrary';
 import { Shrinkable } from '../../../../../src/check/arbitrary/definition/Shrinkable';
-import { constant } from '../../../../../src/check/arbitrary/ConstantArbitrary';
 import { nat } from '../../../../../src/check/arbitrary/IntegerArbitrary';
 import { tuple } from '../../../../../src/check/arbitrary/TupleArbitrary';
 import { Random } from '../../../../../src/random/generator/Random';
 import { stream } from '../../../../../src/stream/Stream';
 
 import * as genericHelper from '../generic/GenericArbitraryHelper';
 
-import * as stubArb from '../../../stubs/arbitraries';
 import * as stubRng from '../../../stubs/generators';
 
 class ForwardArbitrary extends Arbitrary<number> {

diff --git a/test/unit/check/runner/Sampler.spec.ts b/test/unit/check/runner/Sampler.spec.ts
@@ -50,7 +50,7 @@ describe('Sampler', () => {
       fc.assert(
         fc.property(fc.nat(MAX_NUM_RUNS), fc.integer(), (num, start) => {
           const arb = stubArb.counter(start);
-          const out = sample(arb, num);
+          sample(arb, num);
           assert.equal(arb.generatedValues.length, num, 'Should not call the arbitrary too many times');
         })
       ));
@@ -189,7 +189,7 @@ describe('Sampler', () => {
         fc.property(fc.nat(MAX_NUM_RUNS), fc.integer(), (num, start) => {
           const classify = (g: number) => g.toString();
           const arb = stubArb.counter(start);
-          const out = statistics(arb, classify, { numRuns: num, logger: (v: string) => {} });
+          statistics(arb, classify, { numRuns: num, logger: (v: string) => {} });
           assert.equal(arb.generatedValues.length, num, 'Should not call the arbitrary too many times');
         })
       ));

diff --git a/test/unit/random/generator/Random.spec.ts b/test/unit/random/generator/Random.spec.ts
@@ -1,4 +1,3 @@
-import * as assert from 'assert';
 import * as prand from 'pure-rand';
 import * as fc from '../../../../lib/fast-check';
 
@@ -11,7 +10,7 @@ describe('Random', () => {
       fc.assert(
         fc.property(fc.integer(), fc.nat(31), fc.nat(MAX_SIZE), (seed, n, num) => {
           const mrng = new Random(prand.xorshift128plus(seed));
-          for (let idx = 0; idx != num; ++idx) {
+          for (let idx = 0; idx !== num; ++idx) {
             const v = mrng.next(n);
             if (v < 0 || v > (((1 << n) - 1) | 0)) return false;
           }
@@ -26,7 +25,7 @@ describe('Random', () => {
           const mrng = new Random(prand.xorshift128plus(seed));
           const min = a < b ? a : b;
           const max = a < b ? b : a;
-          for (let idx = 0; idx != num; ++idx) {
+          for (let idx = 0; idx !== num; ++idx) {
             const v = mrng.nextInt(min, max);
             if (min > v || max < v) return false;
           }
@@ -38,7 +37,7 @@ describe('Random', () => {
         fc.property(fc.integer(), fc.nat(MAX_SIZE), (seed, num) => {
           const mrng1 = new Random(prand.xorshift128plus(seed));
           const mrng2 = new Random(prand.xorshift128plus(seed));
-          for (let idx = 0; idx != num; ++idx) if (mrng1.nextInt() != mrng2.nextInt()) return false;
+          for (let idx = 0; idx !== num; ++idx) if (mrng1.nextInt() !== mrng2.nextInt()) return false;
           return true;
         })
       ));
@@ -48,7 +47,7 @@ describe('Random', () => {
       fc.assert(
         fc.property(fc.integer(), fc.nat(MAX_SIZE), (seed, num) => {
           const mrng = new Random(prand.xorshift128plus(seed));
-          for (let idx = 0; idx != num; ++idx) {
+          for (let idx = 0; idx !== num; ++idx) {
             const v = mrng.nextDouble();
             if (v < 0 || v >= 1) return false;
           }
@@ -62,7 +61,7 @@ describe('Random', () => {
         fc.property(fc.integer(), fc.nat(MAX_SIZE), (seed, num) => {
           const mrng1 = new Random(prand.xorshift128plus(seed));
           const mrng2 = mrng1.clone();
-          for (let idx = 0; idx != num; ++idx) if (mrng1.nextInt() != mrng2.nextInt()) return false;
+          for (let idx = 0; idx !== num; ++idx) if (mrng1.nextInt() !== mrng2.nextInt()) return false;
           return true;
         })
       ));

diff --git a/test/unit/stream/Stream.spec.ts b/test/unit/stream/Stream.spec.ts
@@ -290,7 +290,6 @@ describe('Stream', () => {
       assert.deepEqual(v, 19);
     });
     it('Should be null for empty streams', () => {
-      function* g(): IterableIterator<number> {}
       let v = Stream.nil<number>().getNthOrLast(10);
       assert.deepEqual(v, null);
     });

diff --git a/tsconfig.json b/tsconfig.json
@@ -5,6 +5,7 @@
         "alwaysStrict": true,
         "noImplicitAny": true,
         "noImplicitThis": true,
+        "noUnusedLocals": true,
         "removeComments": false,
         "preserveConstEnums": true,
         "strictNullChecks": true,

diff --git a/tslint.json b/tslint.json
@@ -13,7 +13,6 @@
         "no-bitwise": false,
         "no-namespace": false,
         "no-unnecessary-callback-wrapper": false, // a.map(f) != a.map(e => f(e))
-        "no-unused-variable": true,
         "unified-signatures": false,
         // Format (handled by prettier if needed)
         "curly": false,