Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink of commands stops at first level (regression 1.8.0) #254

Closed
dubzzz opened this issue Dec 12, 2018 · 3 comments
Closed

Shrink of commands stops at first level (regression 1.8.0) #254

dubzzz opened this issue Dec 12, 2018 · 3 comments

Comments

@dubzzz
Copy link
Owner

dubzzz commented Dec 12, 2018

More at https://travis-ci.org/dubzzz/fast-check/jobs/466197284

@dubzzz dubzzz added the bug label Dec 12, 2018
@dubzzz
Copy link
Owner Author

dubzzz commented Dec 12, 2018

 1) CommandsArbitrary (seed: 1544476043199) commands Should print only the commands corresponding to the failure: AssertionError [ERR_ASSERTION]: Expected the only played command to be 'failure', got: success,failure for steps 0,1 + expected - actual -success,failure +failure at Context.<anonymous> (test/e2e/model/CommandsArbitrary.spec.ts:60:14) 

@dubzzz
Copy link
Owner Author

dubzzz commented Dec 13, 2018

Bug might be the line 53 of https://github.com/dubzzz/fast-check/blob/master/src/check/model/commands/CommandsArbitrary.ts

size has to be used with shrunkOnce = false

A test have to be designed to detect more easily such issues in the future :)

@dubzzz
Copy link
Owner Author

dubzzz commented Dec 14, 2018

It seems to be a regression coming from #235 in 1.8.0. I am currently working on patch that should be integrated into 1.8.2 release (fixes the shrink of fc.commands).

@dubzzz dubzzz pinned this issue Dec 14, 2018
@dubzzz dubzzz changed the title Shrink of commands keeps unnecessary ones Shrink of commands keeps unnecessary ones (regression 1.8.0) Dec 14, 2018
@dubzzz dubzzz changed the title Shrink of commands keeps unnecessary ones (regression 1.8.0) Shrink of commands stops at first level (regression 1.8.0) Dec 14, 2018
dubzzz added a commit that referenced this issue Dec 14, 2018
@dubzzz dubzzz closed this as completed in e4de051 Dec 15, 2018
@dubzzz dubzzz unpinned this issue Dec 15, 2018
dubzzz added a commit that referenced this issue Dec 15, 2018
dubzzz added a commit that referenced this issue Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant