Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug reported by CI #3478

Closed
dubzzz opened this issue Dec 11, 2022 · 2 comments 路 Fixed by #3880
Closed

Bug reported by CI #3478

dubzzz opened this issue Dec 11, 2022 · 2 comments 路 Fixed by #3880
Labels
鉁旓笍 Bug Confirmed 馃悰 Bug Report

Comments

@dubzzz
Copy link
Owner

dubzzz commented Dec 11, 2022

馃悰 Bug Report

Screenshot_20221211-234113
@stale
Copy link

stale bot commented Mar 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 12, 2023
@dubzzz dubzzz removed the stale label Mar 12, 2023
@dubzzz
Copy link
Owner Author

dubzzz commented May 17, 2023

The problem comes from the fact that fc.stringify({ ['__proto__']: 1 }) serializes into "{ ['__proto__']: 1 }" and not "{ '__proto__': 1 }". On the other hand, JSON.stringify fails to properly handle -0. So neither fc.stringify, not JSON.stringify fit our needs for this test...

dubzzz added a commit that referenced this issue May 17, 2023
@dubzzz
馃挌 Stabilize tests on jsonValue
c54e901 
THe current implementation of the test suffered from the fact that `fc.stringify` was producing valid JS values while `JSON.parse` was expecting valid JSON values. As the two specs are not fully aligned being a valid JS value does not imply being a valid JSON one.

Fixes #3478
@dubzzz dubzzz mentioned this issue May 17, 2023
Merged
12 tasks
dubzzz added a commit that referenced this issue May 17, 2023
@dubzzz
馃挌 Stabilize tests on jsonValue (#3880)
12aa34d 
THe current implementation of the test suffered from the fact that `fc.stringify` was producing valid JS values while `JSON.parse` was expecting valid JSON values. As the two specs are not fully aligned being a valid JS value does not imply being a valid JSON one.

Fixes #3478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
鉁旓笍 Bug Confirmed 馃悰 Bug Report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

馃挌 Stabilize tests on jsonValue dubzzz/fast-check
1 participant
@dubzzz