Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add files to package.json #547

Closed
gcanti opened this issue Feb 4, 2020 · 2 comments
Closed

add files to package.json #547

gcanti opened this issue Feb 4, 2020 · 2 comments
Labels
✔️ Feature Accepted 💡 Idea

Comments

@gcanti
Copy link

gcanti commented Feb 4, 2020

💡 Idea

After installing fast-check@latest (v1.22.1) I can see in node_modules lots of unnecessary files

fast-check-node-modules

I suggest to add the files entry to package.json (which whitelists rather than blacklists like .npmignore)
dubzzz added a commit that referenced this issue Feb 7, 2020
@dubzzz
Replace .npmignore by "files" field in package.json
ceb7896 
Related to #547
@dubzzz dubzzz mentioned this issue Feb 7, 2020
Merged
dubzzz added a commit that referenced this issue Feb 10, 2020
@dubzzz
🔧 Replace .npmignore by "files" field in package.json (#550)
9c797cb 
Related to #547
@dubzzz
Copy link
Owner

dubzzz commented Feb 10, 2020

Thanks a lot for the suggestion

The fix — #550 — has been published with version 1.22.2 of fast-check

Please free to re-open if you were thinking of something else with this issue ;)

@dubzzz dubzzz closed this as completed Feb 10, 2020
@gcanti
Copy link
Author

gcanti commented Feb 11, 2020

Just installed, I can confirm that there's no more unnecessary files, thank you for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✔️ Feature Accepted 💡 Idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcanti @dubzzz