Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›πŸ·οΈ Fix wrongly typed fc.record(recordModel) #1142

Merged
merged 2 commits into from Nov 7, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Nov 7, 2020

In a nutshell

Fixes #1141

❌ New feature
βœ”οΈ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(βœ”οΈ: yes, ❌: no)

Potential impacts

Typings impact on fc.record

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e9716cd:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.406% when pulling e9716cd on fix-wrongly-typed-records into 6e1173e on master.

@dubzzz dubzzz merged commit ee4b2de into master Nov 7, 2020
@dubzzz dubzzz deleted the fix-wrongly-typed-records branch November 7, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fc.record<T> typechecks to produce Partial<T>
2 participants