Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› SchedulerArbitrary is wrongly cloning the passed Random #1787

Merged
merged 2 commits into from Apr 23, 2021

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 23, 2021

In a nutshell

❌ New feature
βœ”οΈ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(βœ”οΈ: yes, ❌: no)

Potential impacts

Mostly shrinked values of scheduler.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 670f50c:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1787 (670f50c) into main (26daa31) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         121      121           
  Lines        3662     3663    +1     
  Branches      718      718           
=======================================
+ Hits         3554     3555    +1     
  Misses        104      104           
  Partials        4        4           
Flag Coverage Ξ”
unit-tests 97.05% <100.00%> (+<0.01%) ⬆️
unit-tests-10.x-Linux 97.05% <100.00%> (+<0.01%) ⬆️
unit-tests-12.x-Linux 97.05% <100.00%> (+<0.01%) ⬆️
unit-tests-14.x-Linux 97.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
src/arbitrary/_internals/SchedulerArbitrary.ts 78.94% <100.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 26daa31...670f50c. Read the comment docs.

@dubzzz dubzzz merged commit d9724c7 into main Apr 23, 2021
@dubzzz dubzzz deleted the fix-bad-clones branch April 23, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant