Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce technical debt reported by CodeClimate #297

Merged
merged 3 commits into from Jan 29, 2019
Merged

Reduce technical debt reported by CodeClimate #297

merged 3 commits into from Jan 29, 2019

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 28, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 28, 2019 •
edited

Coverage Status

Coverage increased (+0.07%) to 97.487% when pulling 3e9153b on clean/code into afdfc98 on master.

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 29, 2019

According to https://codeclimate.com/github/dubzzz/fast-check/pull/297

CodeClimate debt reduction in Runner:

  • 35min - Function runIt has 5 arguments (exceeds 4 allowed). Consider refactoring
  • 35min - Function asyncRunIt has 5 arguments (exceeds 4 allowed). Consider refactoring
  • 1hr - Function runIt has 32 lines of code (exceeds 25 allowed). Consider refactoring
  • 1hr - Function asyncRunIt has 32 lines of code (exceeds 25 allowed). Consider refactoring
  • 1hr - Identical blocks of code found in 2 locations. Consider refactoring
  • 1hr - Identical blocks of code found in 2 locations. Consider refactoring
  • 1hr - Identical blocks of code found in 2 locations. Consider refactoring
  • 1hr - Identical blocks of code found in 2 locations. Consider refactoring

CodeClimate debt reduction in FunctionArbitrary:

  • 2hrs - Identical blocks of code found in 2 locations. Consider refactoring
  • 2hrs - Identical blocks of code found in 2 locations. Consider refactoring
  • 5hrs - Identical blocks of code found in 2 locations. Consider refactoring
  • 5hrs - Identical blocks of code found in 2 locations. Consider refactoring

@dubzzz dubzzz merged commit 98cf9d0 into master Jan 29, 2019
@dubzzz dubzzz deleted the clean/code branch January 29, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dubzzz @coveralls