Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Correctly parse look{ahead,behind} in regexes #3930

Merged
merged 3 commits into from May 30, 2023
Merged

✨ Correctly parse look{ahead,behind} in regexes #3930

merged 3 commits into from May 30, 2023

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 30, 2023

Not yet supported at generate time, we at least can flag them as not supported.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f45015c:

Sandbox Source
Vanilla Configuration

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3930 (f45015c) into main (61771fe) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main    #3930      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files         208      208              
  Lines        5701     5716      +15     
  Branches     1283     1290       +7     
==========================================
+ Hits         5404     5418      +14     
- Misses        280      281       +1     
  Partials       17       17              
Flag Coverage Δ
unit-tests 94.78% <94.11%> (-0.01%) ⬇️
unit-tests-14.x-Linux 94.78% <94.11%> (-0.01%) ⬇️
unit-tests-16.x-Linux ?
unit-tests-18.x-Linux ?
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/fast-check/src/arbitrary/stringMatching.ts 78.88% <66.66%> (-0.66%) ⬇️
...heck/src/arbitrary/_internals/helpers/ReadRegex.ts 90.47% <100.00%> (+0.39%) ⬆️
.../src/arbitrary/_internals/helpers/TokenizeRegex.ts 94.56% <100.00%> (+0.24%) ⬆️

@dubzzz dubzzz merged commit 951ecf8 into main May 30, 2023
73 of 75 checks passed
@dubzzz dubzzz deleted the look-ahead branch May 30, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant