✅ Rework checks against legacy node

.github/workflows/build-status.yml

@@ -332,6 +332,11 @@ jobs:
         run: yarn workspaces foreach -pvi --no-private exec "git restore -s@ -SW -- test-bundle || true"
       - name: Check bundles
         run: yarn workspaces foreach -pvi --no-private run test-bundle
+      - name: Check legacy bundles
+        run: |
+          git clone --branch v1.7.1 --depth 1 https://github.com/jasongin/nvs ~/.nvs
+          . ~/.nvs/nvs.sh install
+          yarn workspaces foreach -pvi --no-private run test-legacy-bundle
       - name: Check publication lint
         run: yarn publint:all
   test_types:
@@ -396,48 +401,6 @@ jobs:
           cd packages/test-types
           sed -i 's/fc-expect-error-require-exactOptionalPropertyTypes/ts-expect-error/g' *.ts
           yarn dlx -p typescript@${{matrix.ts-version}} tsc --exactOptionalPropertyTypes
-  test_node_8:
-    name: 'Test legacy Node'
-    needs:
-      - warmup_yarn_cache
-      - production_packages
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
-      - name: Using Node v18.x
-        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
-        with:
-          node-version: '18.x'
-          cache: 'yarn'
-          check-latest: true
-      - name: Install dependencies
-        run: yarn install --immutable
-      - name: Download production packages
-        uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
-        with:
-          name: bundles
-          path: packages/
-      - name: Unpack production packages
-        run: yarn unpack:all
-      - name: Alter internals to behave as if published
-        run: yarn workspaces foreach -pRvi --from '@fast-check/test-minimal-support' --no-private exec yarn node $(yarn bin packaged) --keep-node-modules
-      - name: Using Node v8.x
-        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
-        with:
-          node-version: '8.x'
-          check-latest: true
-      - name: Test packages/test-minimal-support/
-        run: |
-          cd packages/test-minimal-support
-          node --version
-          node main.js
-      # Re-install node 16, for clean-up related logic as it does not work with node 8
-      # The caching logic of actions/setup-node calls yarn to know the version
-      - name: Using Node v18.x
-        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
-        with:
-          node-version: '18.x'
-          check-latest: true
 
   # Publication jobs
   publish_documentation:
@@ -465,7 +428,6 @@ jobs:
       - typecheck
       - test
       - test_bundle
-      - test_node_8
       - test_types
     if: github.event_name == 'push'
     runs-on: ubuntu-latest

.yarn/versions/dcfe3085.yml

@@ -0,0 +1,2 @@
+declined:
+  - fast-check

packages/fast-check/package.json

@@ -39,7 +39,8 @@
     "e2e:watch": "jest --config jest.e2e.config.cjs --watch",
     "e2e:debug": "node --inspect ../../node_modules/jest/bin/jest.js --config jest.e2e.config.cjs --watch --runInBand",
     "update:examples": "cross-env UPDATE_CODE_SNIPPETS=true jest --config jest.examples.config.cjs",
-    "test-bundle": "node test-bundle/run.cjs && node test-bundle/run.mjs",
+    "test-bundle": "node test-bundle/run.cjs && node test-bundle/run.mjs && node test-bundle/run-advanced.cjs",
+    "test-legacy-bundle": "nvs add 8 && $(nvs which 8) test-bundle/run.cjs && $(nvs which 8) test-bundle/run-advanced.cjs",
     "docs": "api-extractor run --local && rm docs/fast-check.api.json && typedoc --out docs src/fast-check-default.ts && node postbuild/main.cjs",
     "docs-ci": "cross-env EXPECT_GITHUB_SHA=true yarn docs",
     "docs:serve": "yarn dlx serve docs/"

packages/test-minimal-support/main.js → packages/fast-check/test-bundle/run-advanced.cjs

@@ -1,5 +1,7 @@
 // @ts-check
+// eslint-disable-next-line @typescript-eslint/no-var-requires, no-undef
 var assert = require('assert');
+// eslint-disable-next-line @typescript-eslint/no-var-requires, no-undef
 var fc = require('fast-check');
 
 function testArbitrary(arb) {
@@ -12,9 +14,10 @@ function testArbitrary(arb) {
 
   // should be able to detect failing runs and report them correctly
   // should be able to shrink with no crash
+  var runId = 0;
   var successfulAssert = true;
   try {
-    var runId = 0;
+    runId = 0;
     fc.assert(
       fc.property(arb, function () {
         return runId++ % 3 === 0;
@@ -28,7 +31,7 @@ function testArbitrary(arb) {
   assert.ok(successfulAssert, 'Assert failed with an unexpected failure');
 
   // should be able to replay a failing case
-  var runId = 0;
+  runId = 0;
   var details = fc.check(
     fc.property(arb, function () {
       return runId++ % 3 === 0;
@@ -53,6 +56,7 @@ function testArbitrary(arb) {
   assert.notEqual(stats.length, 0);
 }
 
+console.log('Starting ' + __filename + '...');
 testArbitrary(fc.nat());
 testArbitrary(fc.subarray([1, 42, 360]));
 testArbitrary(fc.array(fc.nat()));

packages/fast-check/test-bundle/run.cjs

@@ -1,2 +1,4 @@
 const fc = require('fast-check');
+
+console.log('Starting ' + __filename + '...');
 console.log(fc.sample(fc.nat(), { seed: 42, numRuns: 5 }));

packages/fast-check/test-bundle/run.mjs

@@ -1,2 +1,5 @@
 import fc from 'fast-check';
+import * as url from 'url';
+
+console.log('Starting ' + url.fileURLToPath(import.meta.url) + '...');
 console.log(fc.sample(fc.nat(), { seed: 42, numRuns: 5 }));

yarn.lock

@@ -2832,14 +2832,6 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@fast-check/test-minimal-support@workspace:packages/test-minimal-support":
-  version: 0.0.0-use.local
-  resolution: "@fast-check/test-minimal-support@workspace:packages/test-minimal-support"
-  dependencies:
-    fast-check: "workspace:*"
-  languageName: unknown
-  linkType: soft
-
 "@fast-check/test-types@workspace:packages/test-types":
   version: 0.0.0-use.local
   resolution: "@fast-check/test-types@workspace:packages/test-types"