π₯ Error with cause by default #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We offer a fallback for users willing to preserve the old behaviour. Indeed, for now, not all test runners properly support causes attached to the Error. As a consequence, not offering a way to rely on the legacy format would block some users to V3.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 97fbcff:
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## next-3_14_0 #4489 +/- ##
===============================================
+ Coverage 93.29% 93.39% +0.09%
===============================================
Files 207 207
Lines 5013 5013
Branches 1355 1354 -1
===============================================
+ Hits 4677 4682 +5
+ Misses 336 331 -5
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
dubzzz
added a commit
that referenced
this pull request
Jan 2, 2024
**π₯ Breaking change** Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism. This PR makes cause mode the default. Before this PR, toggling it was possible via `errorWithCause: true` on `fc.assert`. Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via `includeErrorInReport: true` on `fc.assert`. Related to #4416.
dubzzz
added a commit
that referenced
this pull request
May 16, 2024
**π₯ Breaking change** Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism. This PR makes cause mode the default. Before this PR, toggling it was possible via `errorWithCause: true` on `fc.assert`. Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via `includeErrorInReport: true` on `fc.assert`. Related to #4416.
dubzzz
added a commit
that referenced
this pull request
May 17, 2024
**π₯ Breaking change** Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism. This PR makes cause mode the default. Before this PR, toggling it was possible via `errorWithCause: true` on `fc.assert`. Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via `includeErrorInReport: true` on `fc.assert`. Related to #4416.
dubzzz
added a commit
that referenced
this pull request
May 29, 2024
**π₯ Breaking change** Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism. This PR makes cause mode the default. Before this PR, toggling it was possible via `errorWithCause: true` on `fc.assert`. Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via `includeErrorInReport: true` on `fc.assert`. Related to #4416.
dubzzz
added a commit
that referenced
this pull request
May 29, 2024
dubzzz
added a commit
that referenced
this pull request
Jul 16, 2024
**π₯ Breaking change** Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism. This PR makes cause mode the default. Before this PR, toggling it was possible via `errorWithCause: true` on `fc.assert`. Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via `includeErrorInReport: true` on `fc.assert`. Related to #4416.
dubzzz
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π₯ Breaking change
Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism.
This PR makes cause mode the default. Before this PR, toggling it was possible via
errorWithCause: trueonfc.assert.Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via
includeErrorInReport: trueonfc.assert.Related to #4416.
Category:
Potential impacts: