✨ Add fc.scheduler arbitrary
#479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzzz
commented
Nov 13, 2019
test/e2e/AsyncScheduler.spec.ts
Outdated
| const handle = buildGraph(initialPackageName, fetch); | ||
| // Or: await s.waitAll(); | ||
| while (s.count() !== 0) { | ||
| expect(s.count()).toBeLessThanOrEqual(Object.keys(allPackages).length); |
There was a problem hiding this comment.
We might add a maxThreadPoolSize parameters with a quitehigh initial value or force the users to define one
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5121fa6:
|
dubzzz
commented
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR for?
Race conditions are the most difficult to debug and to detect issues. Property basedtesting might help to detect such issues earlier by resolving promises in a random order to uncover unexpected orderings causing crashes in our apps.
PR is at a very very early stage. Tests are missings, code is in a single file...
For the moment, I need to gather cases that can be used to illustrate the purpose of such arbitrary. I will put some of those examples into
test/e2e/AsyncScheduler.spec.ts.In a nutshell
✔️ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain
(✔️: yes, ❌: no)
Potential impacts
None.