Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findOrUndefined function. #583

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Add findOrUndefined function. #583

merged 3 commits into from
Apr 25, 2020

Conversation

tinydylan
Copy link
Contributor

This allows us to avoid using Array.prototype.find,
which is not available on Internet Explorer 11.

Why is this PR for?

Addresses issue #582

In a nutshell

❌ New feature
✔️/❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(✔️: yes, ❌: no)

Potential impacts

Slightly larger code size, slightly longer testing time.

This allows us to avoid using Array.prototype.find,
which is not available on Internet Explorer 11.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 471c846:

Sandbox Source
amazing-clarke-skzpn Configuration
great-roentgen-v526i Configuration

@coveralls
Copy link

coveralls commented Apr 22, 2020

Coverage Status

Coverage increased (+0.01%) to 96.145% when pulling 471c846 on tinydylan:issue-582 into f4eaa40 on dubzzz:master.

Copy link
Owner

@dubzzz dubzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just to small typos. We can merge as soon as they get fixed.
Thanks a lot for this PR

test/unit/check/arbitrary/helpers/ArrayHelper.spec.ts Outdated Show resolved Hide resolved
test/unit/check/arbitrary/helpers/ArrayHelper.spec.ts Outdated Show resolved Hide resolved
@dubzzz dubzzz merged commit 8d572d1 into dubzzz:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants