⚡ Improve performances of uniform distributions on wide ranges (#53)

dubzzz · Jul 29, 2020 · a7cc22e · a7cc22e
1 parent a52bbb1
commit a7cc22e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -23,7 +23,8 @@
     "coverage": "cat ./coverage/lcov.info | coveralls",
     "build:bench:old": "tsc --target es6",
     "build:bench:new": "tsc --target es6 --outDir lib-new/",
-    "auto:bench": "git stash && yarn build:bench:old && git stash pop && yarn build:bench:new && node perf/benchmark.js"
+    "bench": "node perf/benchmark.cjs",
+    "auto:bench": "git stash && yarn build:bench:old && git stash pop && yarn build:bench:new && yarn bench"
   },
   "repository": {
     "type": "git",

diff --git a/src/distribution/UniformIntDistribution.ts b/src/distribution/UniformIntDistribution.ts
@@ -21,8 +21,8 @@ function uniformIntInternal(from: number, diff: number, rng: RandomGenerator): [
 
   // Compute number of iterations required to have enough random
   // to build uniform entries in the asked range
-  let FinalNumValues = 1;
-  let NumIterations = 0;
+  let FinalNumValues = NumValues * NumValues;
+  let NumIterations = 2; // At least 2 (at this point in the code)
   while (FinalNumValues < diff) {
     FinalNumValues *= NumValues;
     ++NumIterations;