Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monokai theme #157

Merged
merged 2 commits into from
Jun 19, 2021
Merged

Add monokai theme #157

merged 2 commits into from
Jun 19, 2021

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Jun 19, 2021

Ticks another item from #4

Screenshot 2021-06-19 210243

Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost unreadable in a light terminal, but that's faithful to HTTPie 🙂

Can you add the origin to assets/README.md?

@ducaale ducaale merged commit a5715c5 into develop Jun 19, 2021
@ducaale ducaale deleted the monokai-theme branch June 19, 2021 22:01
@ducaale
Copy link
Owner Author

ducaale commented Jun 19, 2021

Just out of curiosity, is the solarized theme usable in a light terminal when using either HTTPie or xh?

@blyxxyz
Copy link
Collaborator

blyxxyz commented Jun 19, 2021

It's alright:

image

But you can't always expect these themes to work with terminal themes they weren't designed for. Unless they just use the basic color codes that are defined by the terminal theme, like the ansi theme does.

HTTPie has a paraiso-dark and a paraiso-light theme, and one is only readable in dark terminals while the other is only readable in light terminals.

@ducaale ducaale mentioned this pull request Jul 4, 2021
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants