Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use binary prefix in --download #193

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

sorairolake
Copy link
Contributor

@sorairolake sorairolake commented Nov 14, 2021

Use binary prefix instead of SI prefix for disambiguation.

@sorairolake sorairolake changed the title Change to use binary prefix Change to use binary prefix in --download Nov 14, 2021
@ducaale
Copy link
Owner

ducaale commented Nov 14, 2021

As of indicatif v0.16, HumanBytes and BinaryBytes are formatted the same. Do you mind reverting the changes in download.rs to use HumanBytes instead? thanks.

@sorairolake
Copy link
Contributor Author

@ducaale Reverted download.rs.

@ducaale ducaale merged commit f588b08 into ducaale:develop Nov 14, 2021
@sorairolake sorairolake deleted the binary-prefix branch November 14, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants