Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tilde in request items that contain a path #209

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Dec 3, 2021

I have opted not to do the same for paths passed as an argument to flags such as --session and --cert as Bash and Powershell 7.1 both support expanding tilde in paths. Also, see https://stackoverflow.com/a/30027501/5915221.

Resolves #189

Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I have opted not to do the same for paths passed as an argument to flags

I think that's reasonable.

src/utils.rs Show resolved Hide resolved
tests/cli.rs Show resolved Hide resolved
@ducaale ducaale merged commit 03bca22 into develop Dec 4, 2021
@ducaale ducaale deleted the tilde-request-item branch December 4, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants