Automate the generation of negation flags #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only observable difference is that --no-help and --no-version exist now. Those are a bit useless, but HTTPie also has them, so that's okay.
Flags don't take an argument, options might. In the long term we should look at custom subheadings and/or clap_mangen.
ducaale
approved these changes
Feb 15, 2022
Comment on lines
+520
to
+525
| static ARG_STORAGE: OnceCell<Vec<String>> = OnceCell::new(); | ||
| let arg_storage = ARG_STORAGE.get_or_init(|| { | ||
| opts.iter() | ||
| .map(|opt| format!("--no-{}", opt.get_long().expect("long option"))) | ||
| .collect() | ||
| }); |
There was a problem hiding this comment.
It would be great to mention this workaround in clap-rs/clap#815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clap 3 lets us do this.
The only observable difference is that
--no-helpand--no-versionexist now. Those are a bit useless, but HTTPie also has them, so that's okay.