enable stream when content-type is text/event-stream #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea how to write a test case for this feature. |
zuisong
force-pushed
the
auto-enable-stream
branch
3 times, most recently
from
680e8af
to
a107333
Compare
zuisong
force-pushed
the
auto-enable-stream
branch
from
a107333
to
38724cc
Compare
ducaale
reviewed
Apr 10, 2024
|
Not something to address in this PR but I noticed that HTTPie can format payloads contained in individual events $ http https://sse.dev/test --body
data: {
"msg": "It works!",
"now": 1712764259321,
"sse_dev": "is great",
"testing": true
}
data: {
"msg": "It works!",
"now": 1712764261322,
"sse_dev": "is great",
"testing": true
} |
zuisong
force-pushed
the
auto-enable-stream
branch
from
b3e10cc
to
3c985f0
Compare
zuisong
commented
Apr 11, 2024
| self, | ||
| ContentType::Unknown | ContentType::UrlencodedForm | ContentType::Multipart | ||
| ) | ||
| match self { |
There was a problem hiding this comment.
ensure the author updates this method when adding a content-type in the future.
ducaale
reviewed
Apr 11, 2024
ducaale
reviewed
Apr 11, 2024
| @@ -168,8 +168,8 @@ Example: --print=Hb" | |||
| pub quiet: bool, | |||
|
|
|||
| /// Always stream the response body. | |||
| #[clap(short = 'S', long)] | |||
| pub stream: bool, | |||
| #[clap(short = 'S', long, default_missing_value = "true", num_args= 0..=1, require_equals = true)] | |||
There was a problem hiding this comment.
Is there a reason to prefer Option<bool> over bool? It affects the generated help output, but in terms of functionality, the result is the same: false/true versus None/Some(true)
Before
-S, --stream Always stream the response body
After
-S, --stream[=<STREAM>] Always stream the response body [possible values: true, false]
There was a problem hiding this comment.
I think we need to provide users with the ability to choose to turn off automatic print body as stream.
| cli args | stream value | description |
|---|---|---|
| xh -S | Some(true) | alway enable stream |
| xh -S=true | Some(true) | alway enable stream |
| xh -S=false | Some(false) | alway disable stream |
| xh | None | auto enable stream when meet stream body |
zuisong
commented
Apr 11, 2024
| @@ -447,6 +447,9 @@ impl Printer { | |||
| let compression_type = get_compression_type(response.headers()); | |||
| let mut body = decompress(response, compression_type); | |||
|
|
|||
| // Automatically activate stream mode when it hasn't been set by the user and the content type is stream | |||
| let stream = self.stream.unwrap_or(content_type.is_stream()); | |||
There was a problem hiding this comment.
if user set -S=false, it will't print body as stream
ducaale
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #204