Apply TLS options even for non-HTTPS URLs #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS-related options were only being applied for URLs with a `https://` scheme. But that's too cautious, because we could run into a HTTPS URL after a redirect. I've fixed this by just removing the check. Another option is to also check `args.follow`, but I think it's nicer to do this stuff unconditionally. That way we can consistently give errors for bad options (e.g. `--verify=path/wiht/typo`). Test case: ```shell xh --verify=no --follow http://httpbin.org/redirect-to url==https://expired.badssl.com ``` Fixes ducaale#368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS-related options were only being applied for URLs with a
https://scheme. But that's too cautious, because we could run into a HTTPS URL after a redirect.I've fixed this by just removing the check. Another option is to also check
args.follow, but I think it's nicer to do this stuff unconditionally. That way we can consistently give errors for bad options (e.g.--verify=path/wiht/typo).Test case:
Fixes #368.