Avoid getting killed by a bug in Slack. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using shared channels it is possible to receive a user_change event for a user that is on a different team. Additionally, there is currently a bug that causes that event to include the shared channel ID, even if you aren't in it, and even if it's a private channel. That means conversations.info will return an negative response and we die(). Rather than doing that, warn about it and include the channel ID. Slack engineers have been notified about this bug but indicated it could be some time before it is resolved.
duck8823
added a commit
that referenced
this pull request
May 4, 2019
Changelog diff is:
diff --git a/Changes b/Changes
index b0f1c49..090167c 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Slack-RTM-Bot
{{$NEXT}}
+1.12 2019-05-04T01:44:52Z
+
+ - #30 Avoid getting killed by a bug in Slack.
+
1.11 2019-04-27T00:39:51Z
- #29 Slack changed the limit maximum
duck8823
added a commit
that referenced
this pull request
Jul 5, 2020
Changelog diff is:
diff --git a/Changes b/Changes
index 090167c..6ee1321 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Slack-RTM-Bot
{{$NEXT}}
+1.13 2020-07-05T15:03:42Z
+
+ - #35 Use conversations.list
+
1.12 2019-05-04T01:44:52Z
- #30 Avoid getting killed by a bug in Slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using shared channels it is possible to receive a user_change event for a
user that is on a different team.
Additionally, there is currently a bug that causes that event to include the
shared channel ID, even if you aren't in it, and even if it's a private channel.
That means conversations.info will return an negative response and we die().
Rather than doing that, warn about it and include the channel ID.
Slack engineers have been notified about this bug but indicated it could be
some time before it is resolved.