Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip jsdoc checks on windows due to https://github.com/nodejs/node/is… #78

Merged
merged 1 commit into from Apr 22, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Apr 19, 2024

See: nodejs/node#52554, whether node changed an API that lead to this crash.

Failure was like:

  1. JSDoc contains all methods
    "before all" hook for "Database":
    Error: spawn EINVAL
    at ChildProcess.spawn (node:internal/child_process:414:11)
    at spawn (node:child_process:761:9)
    at execFile (node:child_process:351:17)
    at jsdocParser (node_modules\jsdoc3-parser\index.js:58:3)
    at node:internal/util:441:7
    at new Promise ()
    at jsdocParser (node:internal/util:427:12)

unsure whether jsdocParser can be bumped, but looks to be broken still.

Failure is like:
  1) JSDoc contains all methods
       "before all" hook for "Database":
     Error: spawn EINVAL
      at ChildProcess.spawn (node:internal/child_process:414:11)
      at spawn (node:child_process:761:9)
      at execFile (node:child_process:351:17)
      at jsdocParser (node_modules\jsdoc3-parser\index.js:58:3)
      at node:internal/util:441:7
      at new Promise (<anonymous>)
      at jsdocParser (node:internal/util:427:12)

unsure whether jsdocParser can be bumped, but looks to be broken still.
@hannes hannes merged commit 2ab5f7a into duckdb:main Apr 22, 2024
6 checks passed
@carlopi carlopi deleted the skip_jsdoc_win branch April 22, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants