Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prod() translation for dbplyr #40

Merged
merged 2 commits into from Nov 8, 2023
Merged

Conversation

m-muecke
Copy link
Contributor

@m-muecke m-muecke commented Nov 6, 2023

No description provided.

@m-muecke m-muecke changed the title feat: added prod dbplyr translation feat: added prod dbplyr translation Nov 6, 2023
@krlmlr
Copy link
Collaborator

krlmlr commented Nov 8, 2023

Thanks. What would a test for this and other functionality look like?

@m-muecke
Copy link
Contributor Author

m-muecke commented Nov 8, 2023

Thanks. What would a test for this and other functionality look like?

I have added some tests for the current agg functions. What is the scope difference between the duckdb and the duckplyr package for dplyr translations, they seem to overlap.

@krlmlr
Copy link
Collaborator

krlmlr commented Nov 8, 2023

duckplyr is data frame in, data frame out, with full compatibility and fallback to dplyr if needed.

@krlmlr krlmlr changed the title feat: added prod dbplyr translation feat: Add prod() translation for dbplyr Nov 8, 2023
@krlmlr krlmlr merged commit d8c4235 into duckdb:main Nov 8, 2023
18 checks passed
@krlmlr
Copy link
Collaborator

krlmlr commented Nov 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants