Add install.libs script to remove debug symbols#185
Closed
hannes wants to merge 1 commit intoduckdb:mainfrom
Closed
Add install.libs script to remove debug symbols#185hannes wants to merge 1 commit intoduckdb:mainfrom
hannes wants to merge 1 commit intoduckdb:mainfrom
Conversation
Collaborator
|
Thanks. This seems to be a copy of the code in WRE in https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Package-subdirectories . Do we need to adapt this to achieve the desired behavior? Why does adding this file reduce the size of the shared library? |
Collaborator
|
Thanks, now part of duckdb 1.0.0-2, on CRAN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom install script, somehow makes CRAN not ship debug symbols ^^
thanks @gaborcsardi