Feedbacks

Signed-off-by: Pradeep Chhetri <pradeepchhetri4444@gmail.com>

src/cache.rs

@@ -280,37 +280,27 @@ mod test {
         "#,
         )?;
 
-        let sql = "SELECT x FROM foo";
+        let sql = "SELECT * FROM foo";
 
         {
             let mut stmt = db.prepare_cached(sql)?;
             assert_eq!(Ok(Some(1i32)), stmt.query([])?.map(|r| r.get(0)).next());
         }
 
-        let sql_cannot_cache = "SELECT * FROM foo";
-
-        {
-            let mut stmt = db.prepare_cached(sql_cannot_cache)?;
-            assert_eq!(Ok(Some(1i32)), stmt.query([])?.map(|r| r.get(0)).next());
-        }
-
         db.execute_batch(
             r#"
             ALTER TABLE foo ADD COLUMN y INT;
             UPDATE foo SET y = 2;
         "#,
         )?;
 
-        {
-            let mut stmt = db.prepare_cached(sql)?;
-            assert_eq!(Ok(Some(1i32)), stmt.query([])?.map(|r| r.get(0)).next());
-        }
-
         {
             // Rebinding statement after catalog change resulted in change of types
-            let mut stmt = db.prepare_cached(sql_cannot_cache)?;
-            let result = stmt.query([]);
-            assert!(result.is_err());
+            let mut stmt = db.prepare_cached(sql)?;
+            assert_eq!(
+                Ok(Some((1i32, 2i32))),
+                stmt.query([])?.map(|r| <(i32, i32)>::try_from(r)).next()
+            );
         }
         Ok(())
     }

src/types/to_sql.rs

@@ -328,8 +328,8 @@ mod test {
         let id_vec = id.as_bytes().to_vec();
         db.execute("INSERT INTO foo (id, label) VALUES (?, ?)", params![id_vec, "target"])?;
 
-        let mut stmt = db.prepare("SELECT id, label FROM foo WHERE id = ?")?;
-        let mut rows = stmt.query(params![id_vec])?;
+        let mut stmt = db.prepare("SELECT id, label FROM foo")?;
+        let mut rows = stmt.query([])?;
         let row = rows.next()?.unwrap();
         let found_id: Uuid = row.get_unwrap(0);
         let found_label: String = row.get_unwrap(1);