Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl cache for prepared_stmt #67

Merged
merged 1 commit into from Jul 24, 2022
Merged

impl cache for prepared_stmt #67

merged 1 commit into from Jul 24, 2022

Conversation

wangfenjin
Copy link
Collaborator

Close #58

Change-Id: I9276afeb167e252ad1ad083c6fa20faa22ed4579
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #67 (9c73ec2) into main (213b1a5) will increase coverage by 1.02%.
The diff coverage is 93.19%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   76.01%   77.04%   +1.02%     
==========================================
  Files          25       26       +1     
  Lines        2502     2649     +147     
==========================================
+ Hits         1902     2041     +139     
- Misses        600      608       +8     
Impacted Files Coverage Δ
src/statement.rs 89.47% <75.00%> (-0.26%) ⬇️
src/raw_statement.rs 67.04% <83.33%> (+3.63%) ⬆️
src/cache.rs 94.07% <94.07%> (ø)
src/lib.rs 90.59% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

#[inline]
pub fn clear_bindings(&self) -> ffi::duckdb_state {
// unsafe { ffi::sqlite3_clear_bindings(self.ptr) }
DuckDBSuccess
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: impl this function after duckdb support it

@wangfenjin wangfenjin merged commit 80f6f90 into main Jul 24, 2022
@wangfenjin wangfenjin deleted the cache-prepared branch July 24, 2022 14:54
@wangfenjin wangfenjin added the feature Used for auto generate changelog label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Used for auto generate changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r2d2: prepare_cached support needed
1 participant