-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nitpickings #13
Nitpickings #13
Conversation
I don't know, that seems like a mistake (but you would need to ask the designers there).
My vote goes to all uppercase for clarity.
Yes, so is STRING, etc. We currently don't support a "proper" CHAR type that includes padding with spaces on output, and I'm not sure that we ever will. It seems like legacy to me that was introduced for database developer convenience. I can't really envision a use case for CHAR instead of VARCHAR.
I think the |
The static page generator replaces them with proper quotes when rendering the page
The minvalue (descending) / maxvalue (ascending) defaults in https://duckdb.org/docs/sql/statements/create_sequence seem incorrect. The code states: if (info->increment < 0) {
info->start_value = info->max_value = -1;
info->min_value = NumericLimits<int64_t>::Minimum();
} else {
info->start_value = info->min_value = 1;
info->max_value = NumericLimits<int64_t>::Maximum();
}
If I run
I get
So they seem plus-minus (2^63 - 1). |
This is related to null values within the domain that are still in some places in the system. Once those are removed the minimum value will be updated to those bounds. I think this is not worth changing since it will need to be updated later on again when we solve that issue (which we will likely forget :)). |
Thanks for the changes. Can you resolve the merge conflict when you have time? After that I think it is ready to be merged. |
Thanks! |
I started going through the docs and iron out some inconsistencies. Most of them are fairly straightforward so instead of opening a dozen PRs, I've batched them in a single one. The commit messages describe the changes in detail.
I have a few questions:
Is there a reason
<em>
texts are rendered as normal (and not italic)?How should we spell type names? Currently it's a mix of all lowercase and all uppercase:
I'm fine both ways but it should be consistent.
Is
CHAR
an alias forVARCHAR
?In this sentence, there seems to be a word missing: "DuckDB contains a columnar-vectorized query execution engine, where queries are still interpreted, but a large batch of values from a single (a “vector”) are processed in one operation" -> from a single what? "chunk"?