Skip to content

Commit

Permalink
Revert "feat: switch to using oldest-supported-numpy"
Browse files Browse the repository at this point in the history
This reverts commit 09a48dd.
  • Loading branch information
Mytherin committed Nov 14, 2022
1 parent b0b0dd9 commit d63df76
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions tools/pythonpkg/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,12 @@ def __str__(self):
library_dirs=library_dirs,
language='c++')

# Only include pytest-runner in setup_requires if we're invoking tests
if {'pytest', 'test', 'ptr'}.intersection(sys.argv):
setup_requires = ['pytest-runner']
else:
setup_requires = []

setuptools_scm_conf = {"root": "../..", "relative_to": __file__}
if os.getenv('SETUPTOOLS_SCM_NO_LOCAL', 'no') != 'no':
setuptools_scm_conf['local_scheme'] = 'no-local-version'
Expand Down Expand Up @@ -274,19 +280,16 @@ def setup_data_files(data_files):
url="https://www.duckdb.org",
long_description = 'See here for an introduction: https://duckdb.org/docs/api/python/overview',
license='MIT',
install_requires=[ # these version is still available for Python 2, newer ones aren't
'numpy>=1.14'
],
data_files = data_files,
packages=[
'duckdb_query_graph',
'duckdb-stubs'
],
test_requires=['pytest-runner'],
include_package_data=True,
setup_requires=[
"setuptools_scm",
"oldest-supported-numpy", # compile against oldest supported numpy version, so we can support any version of numpy (numpy is always backward-compatible)
'pybind11>=2.6.0'
],
requires=['numpy'],
setup_requires=setup_requires + ["setuptools_scm<7.0.0", 'numpy>=1.14', 'pybind11>=2.6.0'],
use_scm_version = setuptools_scm_conf,
tests_require=['google-cloud-storage', 'mypy', 'pytest'],
classifiers = [
Expand Down

0 comments on commit d63df76

Please sign in to comment.