Merge pull request #11981 from Tishj/python_optional_numpy

[Python] Make the NumPy module optional, not throwing if it's not installed
duckdb · May 13, 2024 · fcee4de · fcee4de
2 parents e9e1992 + 6557e56
commit fcee4de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/tools/pythonpkg/scripts/cache_data.json b/tools/pythonpkg/scripts/cache_data.json
@@ -252,7 +252,8 @@
             "numpy.csingle",
             "numpy.cdouble",
             "numpy.clongdouble"
-        ]
+        ],
+        "required": false
     },
     "numpy.core": {
         "type": "attribute",

diff --git a/tools/pythonpkg/src/include/duckdb_python/import_cache/modules/numpy_module.hpp b/tools/pythonpkg/src/include/duckdb_python/import_cache/modules/numpy_module.hpp
@@ -79,6 +79,11 @@ struct NumpyCacheItem : public PythonImportCacheItem {
 	PythonImportCacheItem csingle;
 	PythonImportCacheItem cdouble;
 	PythonImportCacheItem clongdouble;
+
+protected:
+	bool IsRequired() const override final {
+		return false;
+	}
 };
 
 } // namespace duckdb