Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30037\include\functional(940): fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj [C:\Program Files\nodejs\node_modules\duckdb\build\duckdb.vcxproj]" #1910

Closed
tanin47 opened this issue Jun 25, 2021 · 3 comments

Comments

@tanin47
Copy link

tanin47 commented Jun 25, 2021

What does happen?
A short, clear and concise description of what the bug is.

C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30037\include\functional(940): fatal error C1128: number of sections exceeded object file format
 limit: compile with /bigobj [C:\Program Files\nodejs\node_modules\duckdb\build\duckdb.vcxproj]

When installing duckdb 0.2.3 through npm on windows. (i.e. npm install -g duckdb@0.2.3)

A fix would be to add "AdditionalOptions": ["/bigobj"], in binding.gyp.

Apology for reporting a few issues on Windows at the same time. Great project, and I'd love to help making this change since it is straightforward (and I have made this change locally and it builds).

@hannes
Copy link
Member

hannes commented Jun 25, 2021

Could you send a PR please?

@tanin47
Copy link
Author

tanin47 commented Jun 26, 2021

Yes! I'll send the PR soon. I notice that this only happens some of the times as well. I'm not sure why. But I suppose it's still good to have to handle different machines.

@Mytherin
Copy link
Collaborator

This should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants