Node.js Windows Build

[plecong]

Hello!

Fan of DuckDB and have been having issues with the Node.js build on Windows, so thought I'd help out with a few of these issues. This PR adds a GitHub Action job that will pre-build the Windows binary and fixes several issues along the way:

• https://duckdb-node.s3.amazonaws.com/duckdb-v0.2.6-node-v83-win32-x64.tar.gz returns access denied #1903
• Cannot "yarn install" on Windows; Fail with "error C2039: 'RemoveDirectoryA': is not a member" #1908
• "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30037\include\functional(940): fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj [C:\Program Files\nodejs\node_modules\duckdb\build\duckdb.vcxproj]" #1910

One deviation from the current Node.js build for other platforms is that this PR uses a matrix build for Windows instead of nvm used by the Linux/OSX builds as nvm didn't appear to work on Windows. There is NVM for Windows, but the author clearly states that it is not the same thing as nvm, so not pursued further. Due to the matrix build, a new script node_build_win.sh was added instead of using the existing node_build.sh.

Additionally, 523343f and 34327eb address when windows.h is included in physical_load.cpp, however noticed that amalgamation.py has special handling for file_system.cpp to append it at the end. Not sure if this is needed for physical_load.cpp as well.

[Mytherin]

Thanks for the PR! Looks great. Some comments:

Additionally, 523343f and 34327eb address when windows.h is included in physical_load.cpp, however noticed that amalgamation.py has special handling for file_system.cpp to append it at the end. Not sure if this is needed for physical_load.cpp as well.

This should not be necessary anymore. This is a relic from before we "correctly" handled windows.h in our codebase (i.e. by avoiding #define conflicts everywhere). The special handling of file_system.cpp should actually be removed.

[plecong]

In 7575422, the 'relic' code in amalgamation.py for special handling of file_system.cpp has been removed.

[Mytherin]

Thanks, looks great! Will wait for the tests to pass and then I think it is ready to merge from my side.

[Mytherin]

Perhaps @hannesmuehleisen wants to have a look as he made the node.js driver.

[plecong]

@Mytherin Thanks for your review! It does appear that a previous CI build ran into #2100. Will have to see if the latest build with the amalgamation.py changes will pass.

I'm interested in using the Node.js driver to read Parquet files and have a working build locally for #1977 that will be coming after this PR is done.

[Mytherin]

This seems good to merge now, thanks again for the effort!