Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DATETZ type #2780

Closed
hawkfish opened this issue Dec 12, 2021 · 1 comment
Closed

Remove DATETZ type #2780

hawkfish opened this issue Dec 12, 2021 · 1 comment

Comments

@hawkfish
Copy link
Contributor

The ICU extension could be extended to handle DATE WITH TIME ZONE by converting the date_t values to UDates. The rule should be that the given number of days is added to the epoch.

One possible problem here is that ICU likes to left shift negative values, which triggers the address sanitiser. We either need a version of the code that fixes this problem or some hack for dates prior to the epoch.

@hawkfish
Copy link
Contributor Author

hawkfish commented Dec 20, 2021

When I added this I was under the mistaken impression that the standard defined DATE WITH TIME ZONE. It does not; the only other TZ type is TIME, which is largely useless. This bug is now about removing the type from the code.

@hawkfish hawkfish changed the title ICU DATETZ support Remove DATETZ type Dec 21, 2021
hawkfish pushed a commit to hawkfish/duckdb that referenced this issue Dec 21, 2021
This is not a thing, so remove it.
hawkfish pushed a commit to hawkfish/duckdb that referenced this issue Dec 21, 2021
Remove extra double quote.
hawkfish pushed a commit to hawkfish/duckdb that referenced this issue Dec 29, 2021
Remove new Parquet support and dangling formatter.
Mytherin added a commit that referenced this issue Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant